Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 6.6 RC 1: Image cropping fails in the block editor #62855

Closed
andrewserong opened this issue Jun 26, 2024 · 5 comments
Closed

WP 6.6 RC 1: Image cropping fails in the block editor #62855

andrewserong opened this issue Jun 26, 2024 · 5 comments
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Jun 26, 2024

Description

When going to crop an image in the block editor while running WP 6.6 RC 1, the image is not cropped after applying a crop.

The issue appears to be caused by something in core, and not in the Gutenberg plugin, as the values being sent to the media/edit endpoint have not changed.

Related issues:

Step-by-step reproduction instructions

  1. Run WP 6.6 RC 1
  2. Add an image block to a post
  3. Click on the Crop tool in the block toolbar
  4. Select a Crop from the aspect ratio dropdown
  5. Click Apply
  6. Note that the Crop has not applied

Screenshots, screen recording, code snippet

In the below screenshot, an aspect ratio of 1:1 is selected and should be applied, but the returned image from the API endpoint does not include any cropping:

2024-06-26.13.50.32.mp4

Environment info

  • WP 6.6 RC 1
  • Gutenberg not active

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@andrewserong andrewserong added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Jun 26, 2024
@andrewserong
Copy link
Contributor Author

Update: reverting WordPress/wordpress-develop#6876 locally appears to get the image cropping working again for me. I'll comment over on the related trac ticket: https://core.trac.wordpress.org/ticket/59782

@andrewserong
Copy link
Contributor Author

@talldan
Copy link
Contributor

talldan commented Jul 3, 2024

I believe this was fixed by WordPress/wordpress-develop#6909

@talldan talldan closed this as completed Jul 3, 2024
@andrewserong
Copy link
Contributor Author

andrewserong commented Jul 3, 2024

Thanks for updating! Yes it was fixed in WordPress/wordpress-develop#6909, but it hasn't yet been committed to the RC. Since it was missed for RC 2, I'm just going to reopen this for visibility so it doesn't get missed for RC 3. I've moved this back to the "needs core commit" column. Hope you don't mind!

@annezazu
Copy link
Contributor

annezazu commented Jul 9, 2024

Successfully landed in RC3 per https://core.trac.wordpress.org/ticket/61514 Closing out!

@annezazu annezazu closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
3 participants