Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ThemeRoller UI to reflect changes in default theme #249

Open
jaspermdegroot opened this issue Jan 21, 2015 · 2 comments
Open

Update ThemeRoller UI to reflect changes in default theme #249

jaspermdegroot opened this issue Jan 21, 2015 · 2 comments

Comments

@jaspermdegroot
Copy link
Member

The changes in the default theme require the following changes in the ThemeRoller UI:

Those changes should only apply when someone is using 1.12+. For older versions the UI should stay as it is.

@jzaefferer
Copy link
Member

Can we update "flat" to skip the image and only use the color? That is useful for all jQuery UI versions, isn't it?

As for shadow: The outdated controls are still need for older UI versions, and since ThemeRoller itself isn't version-aware, I think we should, for now, just leave them. Though we could reorder them, so that the options relevant for box-shadow come first. We can also add hints to labels or tooltips about the deprecated options.

@rxaviers
Copy link
Member

Can we update "flat" to skip the image and only use the color? That is useful for all jQuery UI versions, isn't it?

Sounds like a good idea. Implemented on #248.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants