Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Start, Trontastic, Vader #569

Open
ferda-mravenec opened this issue Dec 16, 2020 · 3 comments
Open

Themes: Start, Trontastic, Vader #569

ferda-mravenec opened this issue Dec 16, 2020 · 3 comments

Comments

@ferda-mravenec
Copy link

Yesterday I downloaded all themes. This was first time I use themes. For these particular schemes I have entered the CSS Scope as:

  1. "start"
  2. "Trontastic"
  3. "Vader"
    I have also downloaded the rest of themes. Today I have corrected the generated .css files to its correct scope name as section.start, section.trontastic and section.Vader.

Now because this was made automaticly, I got incorrect results number. So I have made regex to find that odds in files.

Lets start with: jquery-ui.css
#214-215:
/* no icon support for input elements */
inputstart .ui-button.ui-button-icon-only {
text-indent: 0;
}

#247-251
inputstart .ui-button::-moz-focus-inner,
buttonstart .ui-button::-moz-focus-inner {
border: 0;
padding: 0;
}
What is the inpustart and buttonstart tags?

For more mistakes seek for these words:
astart
a:linkstart
a:visitedstart
etc.

trontastic and vader has the sameproblems like "inputtrontastic"

Now I have downloaded the start them again this time with "section.start" scope

It's still like:
/* no icon support for input elements */
inputstart .ui-button.ui-button-icon-only {
text-indent: 0;
}

@mgol
Copy link
Member

mgol commented Dec 16, 2020

Thanks for the report. I think this is written in a way that doesn't really work with elements but with classes so you need to prepend a dot to the provided name. @fnagel do you have any insights here?

@fnagel
Copy link
Member

fnagel commented Dec 16, 2020

Mhhhh. As far as I know, you are right. You need to use something like .my-selector as the scope.

Regarding the input .ui-button.ui-button-icon-only rule, I assume there is an glitch in the logic, as the scope should be a prefix, not a selector for the input element.

@ferda-mravenec
Copy link
Author

I have corrected the css files as you can find in my ferda-mravenec/ui repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants