Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Builder: generates files with confusing dates in headers (.css/.js) #605

Open
Chealer opened this issue Nov 7, 2023 · 1 comment

Comments

@Chealer
Copy link

Chealer commented Nov 7, 2023

jQuery UI's (proper) CSS and JavaScript files start with headers, such as the following (from jquery-ui.js in jQuery UI 1.13.2's Development Bundle):

/*! jQuery UI - v1.13.2 - 2022-07-14
* http://jqueryui.com
* Includes: widget.js, [...]
* Copyright jQuery Foundation and other contributors; Licensed MIT */

The date is the release date of this jQuery UI version.

The Download Builder tool is very useful to generate a package of jQuery UI tailored to the user's needs. However, the date in these headers is different for the files it generates. I downloaded a custom build of jQuery UI 1.13.2 today (2023-11-07), and its headers contain:

jQuery UI - v1.13.2 - 2023-11-05

This date corresponds neither to the moment when I downloaded (2023-11-07), nor to jQuery UI 1.13.2's release date. This date is more confusing than helpful.

It should be either removed, fixed or described.

@mgol mgol transferred this issue from jquery/jquery-ui Nov 14, 2023
@mgol
Copy link
Member

mgol commented Nov 14, 2023

Thanks for the report. I transferred it to the Download Builder repository.

The date added is the date when the build was generated. This may be in the past when the build you fetch is cached.

I'd be fine with changing that to the release date of a particular version of jQuery UI. It's probably not a very pressing issue. PRs welcome if they're not too complex.

I think this is the place where the date is generated:

date: today( "isoDate" ),

The cache code is in https://github.com/jquery/download.jqueryui.com/blob/0df89e0efd3e02012185de85e4d6c7787978c8b5/lib/cache.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants