Revert CSS removal for interface footer breadcrumbs #62309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Size Change: +123 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 003d0f2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9377185710
|
ramonjd
approved these changes
Jun 5, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the quick review @ramonjd! I'll merge this in now since it's a visual issue on |
youknowriad
reviewed
Jun 5, 2024
| @@ -163,6 +163,16 @@ html.interface-interface-skeleton__html-container { | |||
| @include break-medium() { | |||
| display: flex; | |||
| } | |||
|
|
|||
| .block-editor-block-breadcrumb { | |||
There was a problem hiding this comment.
Not really clear why this is in the interface package indeed. We can move it to the breadcrumb component directly.
The other thing is that it has a lot of unnecessary stuff. Why it has a background, z-index, ...
ellatrix
added
the
Backport to WP 6.6 Beta/RC
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…#62309) Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.6 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts part of the CSS removal for the interface footer's breadcrumbs rules, removed in #62237
Why?
This CSS added left padding and ensured the height of the footer breadcrumbs was correct when no blocks were selected in the site and post editors. Re-instating the CSS appears to get the styling working again.
There's a comment in https://github.com/WordPress/gutenberg/pull/62237/files#r1624428431 that this CSS was in the wrong place. However, for now, let's re-instate the CSS and it can be moved elsewhere in a follow-up if need be. (I.e. the padding rule is appropriate as a child of the interface footer, but perhaps the height, etc, should be in the breadcrumbs component instead?)
How?
Testing Instructions
trunk, open the post editor and don't select any blocks. Note that the height of the footer breadcrumbs is too small.Testing Instructions for Keyboard
Screenshots or screencast
Before
After