Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themeroller does not include css scope #196

Open
richardy706 opened this issue Feb 14, 2014 · 4 comments
Open

Themeroller does not include css scope #196

richardy706 opened this issue Feb 14, 2014 · 4 comments
Labels

Comments

@richardy706
Copy link

I have been attempting to download a custom theme with a css scope. I enter the folder name and the css scope to use (the scope is the folder name with a . prepended). The zip file appears to include all files but the css files in the css folder do not include the scope in the style rule selectors. The individual widget css files in the themes folder do have the scope but the jquery-ui file in the themes folder does not.

@rxaviers
Copy link
Member

In the downloaded package, do you get ./css/<folderName>/jquery-ui-*.custom.css? Does this file include your scope rule? Also, do you get ./development-bundle/themes/<folderName>/*css? Do these files include your scope rule (each widget, and the bundle jquery-ui.css)?

@richardy706
Copy link
Author

The download package contains the .css//jquery-ui-*-custom.css file but the file does not include the scope rule.

The download package contains the ./development-bundle/themes/ folder. The individual widget css (jquery.ui..css) does contain the scope rule but the jquery-ui.css bundle does not.

Thanks for your help,
Richard

From: Rafael Xavier de Souza [mailto:notifications@github.com]
Sent: Monday, February 17, 2014 10:44 AM
To: jquery/download.jqueryui.com
Cc: Richard Young
Subject: Re: [download.jqueryui.com] Themeroller does not include css scope (#196)

In the downloaded package, do you get ./css//jquery-ui-*.custom.css? Does this file include your scope rule? Also, do you get ./development-bundle/themes/? Do these files include your scope rule (each widget, and the bundle jquery-ui.css)?


Reply to this email directly or view it on GitHubhttps://github.com//issues/196#issuecomment-35294694.

@rxaviers
Copy link
Member

rxaviers commented Feb 17, 2014

Thanks! Bug confirmed.

return css.replace( /(\.ui[^\n,}]*)/g, scope + " $1" );
is not valid anymore for some 1.11 CSS rules, because they are written on multiple lines.

Edit by @mgol: I fixed the link to point to a concrete commit so that it shows the intended line.

@rxaviers rxaviers added the bug label Mar 12, 2014
@srirajmadhavan
Copy link

Hi,

I ran into the same problem. .ui-helper-reset had scope name before (scoped theme downloaded on aug-2013) it and now its removed. Scope name gets applied from /Component containers/ section.

Will this be fixed soon.

Appreciate your help!

Thanks,
SM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants