Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThemeRoller: Clickable Default State and Icon do not generate any css #335

Open
revinhart opened this issue Sep 15, 2016 · 1 comment
Open

ThemeRoller: Clickable Default State and Icon do not generate any css #335

revinhart opened this issue Sep 15, 2016 · 1 comment

Comments

@revinhart
Copy link

revinhart commented Sep 15, 2016 •
edited
Loading

In the theme roller, I can specify Icon for Clickable Default State.
However, when I click "generate" button, the css is missing this line:

.ui-state-default .ui-icon {
background-image: url("images/ui-icons_e0d5d5_256x240.png");
}
@revinhart revinhart changed the title ThemeRoller: Clickable Default State and Icon do not generating any css Sep 15, 2016
arschmitz added a commit to arschmitz/jquery-ui that referenced this issue Sep 29, 2016
@arschmitz
Theme: Switch icon background to use bgColorContent
8e9dc84 
It's more semanticly correct then fcActive and looks the same or better
on most themes

Fixes jquery/download.jqueryui.com#335
arschmitz added a commit to arschmitz/jquery-ui that referenced this issue Sep 29, 2016
@arschmitz
Theme: Replace missing definition for default icons
eeae88a 
Fixes jquery/download.jqueryui.com#335
@arschmitz arschmitz mentioned this issue Sep 29, 2016
Closed
arschmitz added a commit to jquery/jquery-ui that referenced this issue Oct 4, 2016
@arschmitz
Theme: Replace missing definition for default icons
dde9b83 
Fixes jquery/download.jqueryui.com#335
arschmitz added a commit to jquery/jquery-ui that referenced this issue Oct 4, 2016
@arschmitz
Theme: Removes css for ui-state-checked its not used any more
1b0e947 
Also updates checkbox icon border color to go with background color
Ref jquery/download.jqueryui.com#335
Fixes #15059
Closes gh-1753
@revinhart revinhart mentioned this issue Mar 22, 2017
Closed
@mgol mgol mentioned this issue Sep 24, 2021
Merged
mgol added a commit to jquery/jquery-ui that referenced this issue Sep 25, 2021
@mgol
Theme: Revert three theme commits that are causing styling issues (#1983
0fe05e5 
)

* Revert "Theme: Removes css for ui-state-checked its not used any more"

This reverts commit 1b0e947.

* Revert "Theme: Replace missing definition for default icons"

This reverts commit dde9b83.

* Revert "Theme: Switch icon background to use bgColorContent"

This reverts commit 265b8f5.

This reverts three commits:

* Theme: Removes css for ui-state-checked its not used any more 1b0e947 (#1753)
* Theme: Replace missing definition for default icons dde9b83
* Theme: Switch icon background to use bgColorContent 265b8f5

which caused styling issues when compared to UI 1.12.1.

This unfixes a few issues:

* jquery/download.jqueryui.com#335
* https://bugs.jqueryui.com/ticket/15059
* https://forum.jquery.com/topic/checkboxradio-widget-checkbox-click-doesn-t-work-with-ui-lightness-theme-22-9-2016

However, old & known issues are better than new & unknown ones, especially with our current very limited resources.

Closes gh-1983
@mgol
Copy link
Member

mgol commented Sep 25, 2021

This has been unfixed by jquery/jquery-ui#1983 as the fix created new issues and we don't have the capacity to solve them; they seem pretty major.
@mgol mgol reopened this Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@mgol @revinhart