Selectmenu: Remove a call to the deprecated .focus() method #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced call to deprecated jQuery .focus() method with .trigger("focus")
|
|
melloware
approved these changes
Feb 17, 2022
|
Looks good to me. What do you think @mgol We might need to change the commit message (no idea why the PR title looks good though). |
|
@mgol Just for my curiosity: why is the deprecation not mentioned here? https://api.jquery.com/focus/ |
fnagel
approved these changes
Feb 23, 2022
|
@fnagel we haven't documented event shorthand deprecation yet... It's a bit non-standard as those pages also document the details about specific events which we'd like to keep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated call to deprecated jQuery .focus() method in selectmenu.js which was triggering a warning from the migrate plugin