Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020 Design update for API site #1458

Closed
Krinkle opened this issue Jul 8, 2020 · 2 comments
Closed

2020 Design update for API site #1458

Krinkle opened this issue Jul 8, 2020 · 2 comments
Assignees
Labels
Category: Docs Type: Meta Seek input from maintainers and contributors.

Comments

@Krinkle
Copy link
Member

Krinkle commented Jul 8, 2020

Now that the new homepage is live (ref qunitjs/qunitjs.com#151 at https://qunitjs.com), I think we should do a few design touches on the API site (at https://api.qunitjs.com) as well – before we announce the new site publicly as a whole!

/cc @trentmwillis

@Krinkle Krinkle added Type: Meta Seek input from maintainers and contributors. Category: Docs labels Jul 8, 2020
@Krinkle Krinkle self-assigned this Jul 8, 2020
Krinkle added a commit that referenced this issue Jul 11, 2020
* Use the same fonts, colors, header, and syntax highlight styles.

* Add the same footer.

* Split the method name heading from the method signature.
  This is in preparation for #1353.

* On narrow viewports:
  - Hide the sidebar on narrow viewports (redundant with header
    menu).
  - Let tables scroll horizontally instead of widening the page.

Ref #1458
Krinkle added a commit that referenced this issue Jul 11, 2020
* Use the same fonts, colors, header, and syntax highlight styles.

* Add the same footer.

* Split the method name heading from the method signature.
  This is in preparation for #1353.

* On narrow viewports:
  - Hide the sidebar on narrow viewports (redundant with header
    menu).
  - Let tables scroll horizontally instead of widening the page.

Ref #1458
@Krinkle
Copy link
Member Author

Krinkle commented Jul 11, 2020

Old homepage Current draft
Old qunitjs dot com New quntjs dot com

I've prepared a rough draft at https://github.com/qunitjs/qunit/tree/draft-api-design. This is still a work in progress, but ideas and feedback welcome :)

Old API site Current draft Draft; 7 July 2020 Draft; 9 July 2020 Draft; 11 July 2020
Screenshot old Screenshot Interim Screenshot 7 July Screenshot 9 July Screenshot 11 July

I'm fairly satisfied with the above draft (11 July), but the one thing that still stands out to me is the overall "too plain white"-ness. In particular, the suble uses of purple are lost in my opinion due to the stark contrast (they might as well be black). The reason I removed most uses of color from the earlier drafts was to create consistency with the new main site. Its less of an issue there given the hero on each page and the overall shorter content and more headings.

I tried to some some of the color back through the sidebar and link highlights, which are unique to the API site.

Maybe that's good enough for now, but.. I figured I'd experiment with an alternate design that could retain more of the original branding strength. This also in context of last week's jQuery Infra Meeting where the topic of branding was discussed, and how the QUnit work here could be a starting point for other jQuery-family projects looking to adopt a static site. They could use the above draft as starting point, but I feel that one is too plain to still look familiar once the color scheme is changed. Perhaps the below would work better?

Alternate draft: homepage Alternate draft: page Alternate draft: doc entry
Screenshot alt home Screenshot alt page Screenshot alt API

(TODO: search field styling)

Inspiration:

@Krinkle Krinkle mentioned this issue Jul 12, 2020
3 tasks
Krinkle added a commit to qunitjs/qunitjs.com that referenced this issue Jul 20, 2020
* Without the hero banner, the site is quite plain with little
  brandability. Restore some of the QUnit brand colors with a
  darker header. This also allows one of the official logo
  variants to be used, and might also make it a more appealing
  starting point for other jQuery-family sites looking to switch.

* Set width/height on logo image to avoid layout reflow.
  Previously, the search bar would first appear shifted to the
  left and then jump into its proper position after the logo
  file was downloaded.

* Fix bug where search results from a simple page without
  additional headings printed as "Async Control >" with a trailing
  arrow at the end. This was because commit 9a4953d used
  `concat(headings)` with the assumption the property always exists,
  even if just an empty array. This was incorrect. The property is
  undefined if no headings exist on the target page. It is only
  an empty array if headings existed but outside the matched content.
  I don't know if this is intentional on Algolia's part but
  that how it behaves for me today.

Ref qunitjs/qunit#1458.
@Krinkle
Copy link
Member Author

Krinkle commented Jul 21, 2020

Before and after of the version that launched this week:

Old homepage New homepage
Old qunitjs dot com New qunitjs dot com
Old API site New API site
Screenshot old New API site

Tickets:

The design was created by @trentmwillis with some minor adjustments by myself (see previous comments for iterations).

Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
* Without the hero banner, the site is quite plain with little
  brandability. Restore some of the QUnit brand colors with a
  darker header. This also allows one of the official logo
  variants to be used, and might also make it a more appealing
  starting point for other jQuery-family sites looking to switch.

* Set width/height on logo image to avoid layout reflow.
  Previously, the search bar would first appear shifted to the
  left and then jump into its proper position after the logo
  file was downloaded.

* Fix bug where search results from a simple page without
  additional headings printed as "Async Control >" with a trailing
  arrow at the end. This was because commit 9a4953ddc7 used
  `concat(headings)` with the assumption the property always exists,
  even if just an empty array. This was incorrect. The property is
  undefined if no headings exist on the target page. It is only
  an empty array if headings existed but outside the matched content.
  I don't know if this is intentional on Algolia's part but
  that how it behaves for me today.

Ref qunitjs/qunit#1458.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs Type: Meta Seek input from maintainers and contributors.
1 participant