Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Tasks for launch of Jekyll site #151

Closed
7 tasks done
trentmwillis opened this issue Apr 9, 2018 · 5 comments
Closed
7 tasks done

Tasks for launch of Jekyll site #151

trentmwillis opened this issue Apr 9, 2018 · 5 comments
Assignees

Comments

@trentmwillis
Copy link
Member

trentmwillis commented Apr 9, 2018

The following items still need to be addressed before launching:

  • Responsive/cross-browser styles (ensure the styles look good across most major browsers and viewport sizes)
    • Fix iframe on mobile
  • Accessibility (mainly for the nav, most others areas should be good)
    • Run axe-core audit on all the pages
  • Setup search (through Algolia which ESLint has been using)
  • Favicon
  • Point qunitjs.com domain to qunitjs.github.io
@Krinkle
Copy link
Member

Krinkle commented Jun 27, 2020

Old homepage

https://qunitjs.com/

Kept:

  • "What is" tag line
  • Live HTML demo and CLI example.
  • Releases on CDN, npm, yarn, bower.
  • Changelog
  • Pre-release.
  • Link to API docs.

Changed:

  • Pre 2.4 blurp. – Moved to "Intro/Node" page, LGTM. (could also be removed perhaps, but fine for now)
  • Browser support. – Moved to "Intro/Node" page. LGTM.
  • Node.js LTS schedule. – Moved to "Intro/Browser" page. LGTM.
  • Link to plugins. – It is linked from the "Guides" menu, but could do with an inline link as well. Perhaps from the "Extensible" blurb. Anyway, not a blocker for launch. (To be continued at Promote plugins from the home page #100).
  • Link to Cookbook. – Removed, LGTM. (see below)
  • Link to examples (jQuery, jQuery UI, jQuery Validator plugin). – Removed, LGTM. Obsolete with new API docs site.
  • Community: jQuery Testing Forum. – Removed, LGTM. Was abandoned and obsoleted by our public Gitter channel.
  • Community: Chat on IRC. – Removed, LGTM. Was mostly for the team which we moved to a private Gitter channel.
  • Community: Twitter. – Moved to "About/Community" page, LGTM.
  • History. – Moved to "About/History" page. LGTM.

Old intro

https://qunitjs.com/intro/ / https://stage.qunitjs.com/intro/

  • LGTM

Pretty much entirely rewritten but I think that's okay. This has mostly been superseded over the years by our dedicated API docs at https://api.qunitjs.com/. If something comes up later due to a common question or mistake, we can always consider making adjustments later, but overall I like the much smaller and focussed intro page.

Old cookbook

https://qunitjs.com/cookbook/ / https://stage.qunitjs.com/cookbook/

Similar story as with the long intro page. Losing this seems fine for now.

  • Keep a redirect to /intro/?

Old about

https://qunitjs.com/about/ / https://stage.qunitjs.com/about/

  • Vision
  • Team
@Krinkle
Copy link
Member

Krinkle commented Jun 27, 2020

I noticed the new site uses /page instead of /page/ and generates a 404 Not Found if using a trailing slash. We either need to keep redirects or configure Jekyll to use directory-style URLs instead.

For example: https://qunitjs.github.io/plugins/ vs https://qunitjs.github.io/plugins

  • Done.
@Krinkle Krinkle self-assigned this Jun 27, 2020
@Krinkle
Copy link
Member

Krinkle commented Jun 27, 2020

Once these issues are addressed, I will:

@Krinkle Krinkle transferred this issue from qunitjs/qunitjs.github.io Jul 5, 2020
@Krinkle Krinkle changed the title Tasks for launch Jul 5, 2020
Krinkle added a commit to qunitjs/qunitjs.github.io that referenced this issue Jul 5, 2020
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/qunitjs.github.io that referenced this issue Jul 5, 2020
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Use HTTPS for links where possible.

Ref qunitjs/qunitjs.com#151.
Krinkle pushed a commit that referenced this issue Jul 5, 2020
Krinkle pushed a commit that referenced this issue Jul 5, 2020
Setup Travis to run algolia to index content for search.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Use HTTPS for links where possible.

Ref #151.
Krinkle pushed a commit that referenced this issue Jul 5, 2020
Setup Travis to run algolia to index content for search.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Use HTTPS for links where possible.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
Avoid primary purple text color for text that isn't a link.

Ref #151 (comment)
Krinkle added a commit that referenced this issue Jul 5, 2020
Krinkle added a commit that referenced this issue Jul 5, 2020
* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Preserve the /addons/ -> /plugins/ redirect from the  old site.

* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use HTTPS for links where possible.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
Avoid primary purple text color for text that isn't a link.

Ref #151 (comment)
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle Krinkle closed this as completed Jul 7, 2020
@Krinkle
Copy link
Member

Krinkle commented Jul 7, 2020

... and we're live!

Old New
Old qunitjs dot com New quntjs dot com

Next, is to update the API site as see. Filed qunitjs/qunit#1458.

@Krinkle Krinkle mentioned this issue Jul 21, 2020
3 tasks
Krinkle pushed a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
Setup Travis to run algolia to index content for search.

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Preserve the /addons/ -> /plugins/ redirect from the  old site.

* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use HTTPS for links where possible.

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
Avoid primary purple text color for text that isn't a link.

Ref qunitjs/qunitjs.com#151 (comment)
Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
@trentmwillis
Copy link
Member Author

@Krinkle thank you so much for carrying this work over the finish line! Really happy to see this be live 💯 😄

Krinkle added a commit to jquery/jquery-wp-content that referenced this issue Aug 22, 2021
Keep a note of the blog_id because this will still exist on the
actual servers for a while and thus must not be re-used for something
else.

Ref qunitjs/qunitjs.com#151.
Ref jquery/infrastructure#456.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants